Treat ClosedChannelException as UNAVAILABLE to squelch test failures - #1516
Merged
Conversation
| return s; | ||
| } | ||
| if (t instanceof ClosedChannelException) { | ||
| // TODO(ejona): reenable once startup rances are resolved; ClosedChannelException is being seen |
Contributor
|
LGTM |
Our tests are detecting cases where we are still getting ClosedChannelException. We need to fix that because it is a useless status, but until it is fixed we want a stable CI. Fixes grpc#1513 and NettyTransportTest.serverNotListening failures
ejona86
force-pushed
the
squelch-flaky-tests
branch
from
March 3, 2016 22:18
b09795d to
3528467
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our tests are detecting cases where we are still getting
ClosedChannelException. We need to fix that because it is a useless
status, but until it is fixed we want a stable CI.
Fixes #1513 and NettyTransportTest.serverNotListening failures