Skip to content

Fix usage of Protobuf.js Message type in TS file#177

Merged
murgatroid99 merged 1 commit into
grpc:v1.9.xfrom
murgatroid99:ts_message_type_fix
Feb 9, 2018
Merged

Fix usage of Protobuf.js Message type in TS file#177
murgatroid99 merged 1 commit into
grpc:v1.9.xfrom
murgatroid99:ts_message_type_fix

Conversation

@murgatroid99

Copy link
Copy Markdown
Member

This should fix #176.

@kjin kjin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit -- If the payload has to be an object should it be Message<{}> instead?

@murgatroid99

murgatroid99 commented Feb 9, 2018

Copy link
Copy Markdown
Member Author

The Message type here is a Protobuf.js type, not a general type for any kind of message that might be transmitted by gRPC, so it's already an object. And honestly, I put any there because I have no idea what that type parameter means, even after reading Protobuf.js's .d.ts file.

@murgatroid99
murgatroid99 merged commit 42a1530 into grpc:v1.9.x Feb 9, 2018
@lock lock Bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants