Open
Conversation
🦋 Changeset detectedLatest commit: 3c3c7e5 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
📦 npm
Contributor
|
Tip Once this PR is ready to go, add the This saves us a lot of money by not running the tests before we need them. |
Co-authored-by: Name <akinsola.lawanson@guardian.co.uk>
pvighi
force-pushed
the
pv-al/banner_event
branch
from
c3b5eb0 to
3c3c7e5
Compare
pvighi
added
feature
Contributor
|
🐥 |
github-actions
bot
removed
the
🐥 Canaries
Contributor
|
Superseded by #2312 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you changing?
Trigger an event to notify subscribers that the cmp banner was closed
Why?
The Commercial team required an event to ensure mobile sticky ad is not displayed at the same time as the cmp banner