remove unused aws-sdk-client-mock and upgrade to latest gucdk#289
Merged
andrew-nowak merged 1 commit intomainfrom Oct 29, 2025
Merged
remove unused aws-sdk-client-mock and upgrade to latest gucdk#289andrew-nowak merged 1 commit intomainfrom
andrew-nowak merged 1 commit intomainfrom
Conversation
bryophyta
reviewed
Oct 29, 2025
| "scripts": { | ||
| "dev": "EDITION_KEY=US PREFIX_PATH=data/us tsx watch src/handler.ts", | ||
| "typecheck": "tsc -noEmit", | ||
| "build": "esbuild src/handler.ts --bundle --minify --outfile=dist/handler.js --external:aws-sdk --platform=node", |
Contributor
There was a problem hiding this comment.
good catch!
it didn't seem like this change should break anything, because we shouldn't have been using it, but I thought I'd check in CODE anyway just in case there was a sneaky dependency we didn't know about, and it ran fine 👍
bryophyta
approved these changes
Oct 29, 2025
andrew-nowak
added
the
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove the unused aws-sdk-client-mock lib and upgrade to the latest gucdk - together removing our usages of the aws js sdk v2