Skip to content

feat: Add .cts to support typescript 4.7#90

Merged
phated merged 5 commits into
gulpjs:masterfrom
cspotcode:add-cts
Jun 29, 2022
Merged

feat: Add .cts to support typescript 4.7#90
phated merged 5 commits into
gulpjs:masterfrom
cspotcode:add-cts

Conversation

@cspotcode

@cspotcode cspotcode commented May 19, 2022

Copy link
Copy Markdown
Contributor

Resolves #89

This is likely blocked by publication of the next version of ts-node which adds support for the new file extensions.

@cspotcode

Copy link
Copy Markdown
Contributor Author

I've updated this PR to use typescript 4.7 rc, which will become stable in about 4 days, and to use the newest ts-node, which supports cts.

I also removed some of the alternative transpilers from the cts file extension because they were failing. I'm not sure if this was a misconfiguration on my part, or if it was because they don't support .cts.

@phated

phated commented May 21, 2022

Copy link
Copy Markdown
Member

@cspotcode Yeah, I think we should only support this through ts-node as it seems a bit specialized. I'd prefer not to use the RC, so let's wait to land this until 4.7 is released

@phated

phated commented Jun 25, 2022

Copy link
Copy Markdown
Member

@cspotcode has 4.7 been released? I don't keep up on these things. Can you update if so?

@cspotcode

Copy link
Copy Markdown
Contributor Author

Yeah, 4.7 is out, I've updated this PR accordingly.

Comment thread index.js Outdated
Comment thread test/fixtures/cts/1/package.json Outdated
@phated

phated commented Jun 27, 2022

Copy link
Copy Markdown
Member

Couple of comments. Let's get this cleaned up and I'll make a release!

@phated phated changed the title add cts file extension, treated identically to ts feat: Add .cts to support typescript 4.7 Jun 29, 2022

@phated phated left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cspotcode! I cleaned up the non ts-node stuff

@phated phated merged commit c1ffa36 into gulpjs:master Jun 29, 2022
@cspotcode

Copy link
Copy Markdown
Contributor Author

Thanks! I've been super busy, I appreciate it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add .cts file extension

2 participants