CMake clean-up - #5967
Merged
Merged
Conversation
1. Add HEADER output to add_halide_library. 2. Use $<BUILD_INTERFACE:...> in generated target include paths. 3. Clean up logic (reduce nesting). 4. Use lower-case names for local variables. 5. Print paths to detected Clang and LLD config scripts. 6. Honor normal variable overrides for Halide_TARGET.
steven-johnson
approved these changes
May 5, 2021
Contributor
|
OK to land pending green |
alexreinking
force-pushed
the
cmake/pre-pr-cleanup
branch
from
May 5, 2021 20:25
13eab50 to
5516dbd
Compare
shoaibkamil
approved these changes
May 5, 2021
Member
Author
|
I'm going to cancel |
Member
Author
|
CMake is green. Make was cancelled. Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picked from #5754
$<BUILD_INTERFACE:...>in generated target include paths in add_halide_library.