Skip to content

Add workflow to check CMake against Ubuntu-provided dependencies - #9016

Merged
alexreinking merged 23 commits into
mainfrom
alexreinking/test-ecosystem
Mar 13, 2026
Merged

Add workflow to check CMake against Ubuntu-provided dependencies#9016
alexreinking merged 23 commits into
mainfrom
alexreinking/test-ecosystem

Conversation

@alexreinking

@alexreinking alexreinking commented Mar 12, 2026

Copy link
Copy Markdown
Member

We don't want to force vcpkg on our users, and @abadams noticed that our CMake configuration rejects the versions of flatbuffers and wabt that comes with Ubuntu 24.04. This workflow should ensure we don't regress.

Unfortunately, while flatbuffers 2.0.8 appears to work, wabt 1.0.36 is a bit broken: it's missing a dependency on libssl-dev and is not built with -fPIC, so we can't link to it. The new ubuntu-* presets disable the wasm backend by default to account for this.

@alexreinking
alexreinking requested a review from abadams March 12, 2026 20:40
Comment thread src/CMakeLists.txt

@shoaibkamil shoaibkamil left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, otherwise LGTM

@alexreinking
alexreinking merged commit 6a7ed97 into main Mar 13, 2026
27 of 28 checks passed
@alexreinking
alexreinking deleted the alexreinking/test-ecosystem branch March 13, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants