Skip to content

Rework CMake support in buildbot - #61

Merged
steven-johnson merged 1 commit into
masterfrom
srj-cmake
May 27, 2020
Merged

Rework CMake support in buildbot#61
steven-johnson merged 1 commit into
masterfrom
srj-cmake

Conversation

@steven-johnson

Copy link
Copy Markdown
Contributor

In anticipation of halide/Halide#4644 landing, we need better CMake coverage on our buildbots. This refactors to:

  • Pull all the CMake support for building Halide into a non-windows-specific chunk
  • Smarten up the use of CTest to more fully test everything we want to test
  • Hopefully streamline the code some
  • Use Ninja everywhere possible

I'm sure this will take a few tries to get right (we'll have to take down the buildbots to try it out, so scheduling suggestions welcomed) -- offering this up for initial review and comments.

(Note that I wrote this with an eye toward the code in the branch above; it's possible that it may have glitches with our current CMake code in addition to general errors...)

attn @alexreinking

@steven-johnson
steven-johnson requested a review from abadams May 14, 2020 01:05
@alexreinking

alexreinking commented May 14, 2020

Copy link
Copy Markdown
Member

Prefer running cmake --build . --config <config> -j <cpus> to ninja for two reasons:

  1. ninja uses all cores by default - I'm not sure if this is desirable.
  2. The cmake --build ... command works regardless of which generator is being used.

The --config <config> part is only mandatory when building with a multi-config generator like VS or Xcode.

@abadams

abadams commented May 14, 2020

Copy link
Copy Markdown
Member

LGTM so I'll hit approve, but I'm not confident I'd find issues. I'll defer to Alex.

@abadams

abadams commented May 14, 2020

Copy link
Copy Markdown
Member

Oh, I guess it's still a draft so I can't hit approve. LGTM regardless.

@alexreinking

Copy link
Copy Markdown
Member

Pls squash before merging

In anticipation of halide/Halide#4644 landing, we need better CMake coverage on our buildbots. This refactors to:

- Pull all the CMake support for building Halide into a non-windows-specific chunk
- Smarten up the use of CTest to more fully test everything we want to test
- Hopefully streamline the code some
- Use Ninja everywhere possible
@steven-johnson
steven-johnson marked this pull request as ready for review May 27, 2020 17:27
@steven-johnson
steven-johnson merged commit 7d8f76b into master May 27, 2020
@steven-johnson
steven-johnson deleted the srj-cmake branch May 27, 2020 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants