Change error return values in WikiPage::getSection() and setText() (fixes #116)

[Xymph]

See issue #116.

[waldyrious]

I've left two suggestions, neither deal-breakers (so I'm marking the review as "comment" rather than "request changes").

[Xymph]

I went back and forth a bit on the changelog section header btw, hence the first pair of force-pushes. In the same section will be the error code change in login() and I didn't want to put the API-breaking warning in both Changed and Fixed sections. In this PR the getSection commit is more of a change and the setText commit is a fix, but altogether I eventually settled on the Changed section header.

[waldyrious]

In this PR the getSection commit is more of a change and the setText commit is a fix, but altogether I eventually settled on the Changed section header.

Good call. By the way, that reminds me of a comment I read a while ago: "all changes are potentially breaking, including so-called "bug fixes", which are just breaking changes where we have made a judgement call that no one is likely to have been relying on the old behavior."

(and, of course, the relevant xkcd 😄)

[waldyrious]

Just a tiny nitpick 😅

[waldyrious]

Aw, come on, don't make me feel bad for requesting these lines to be added in the first commit 😅 (Or at least, have the changelog update as a separate commit to either change.)

[Xymph]

No intention to do that, but I'm not sure what you're aiming for. Should I move the getSection changelog entry into the first commit with the code change, or split off something into a third commit? How? Figured something out. Hmm, that didn't work yet.

Ok, I give up, bedtime for me.

[waldyrious]

Should I move the getSection changelog entry into the first commit with the code change, or split off something into a third commit?

Either should work. Probably having the changelog in a separate commit is easier, but here's how I'd do both:

1. git rebase -i master, change the first commit's line in the rebase editor from pick to edit, and when the rebase pauses there, I'd make the change to the changelog and then git commit --amend, git rebase --continue. Hopefully git would automatically detect the duplicated changes in the second commit and simply apply the difference.

or

2. git reset HEAD~ (which I have aliased to git uncommit, btw) to undo the latest commit and leave its changes in the working directory, then git add Wikimate.php, make the commit, and then git add CHANGELOG.md and make that commit.

Since you're gone and I've given you this trouble, let me see if I can do it myself.

[waldyrious]

Ok, option 1 worked. Git was smart enough to finish the rebase cleanly for me :) I'll go ahead and merge. Once again, sorry for the trouble! 😅