Skip to content

Add usage documentation about maximum lag and retries#134

Merged
waldyrious merged 1 commit intohamstar:masterfrom
Xymph:134-document-maxlag
Aug 29, 2021
Merged

Add usage documentation about maximum lag and retries#134
waldyrious merged 1 commit intohamstar:masterfrom
Xymph:134-document-maxlag

Conversation

@Xymph
Copy link
Copy Markdown
Collaborator

@Xymph Xymph commented Aug 29, 2021

In all the work and discussion regarding #112, I took a shortcut in not documenting the feature, and my trusty reviewer didn't remind me about it either. 😉

The text already uses WikimateException which doesn't exist yet, but will be defined in my next PR (after this and #133 are merged).

Copy link
Copy Markdown
Collaborator

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) I'll wait until this is rebased to merge it.

@waldyrious
Copy link
Copy Markdown
Collaborator

(I do have to mention that I feel a little uneasy with the time-traveling aspect of an earlier commit mentioning a concept that will be introduced in a later commit, but hey, nothing wrong with leaving a little mystery to the future code archeologists :P)

@Xymph Xymph force-pushed the 134-document-maxlag branch from c91bf7c to 3323db8 Compare August 29, 2021 17:37
@Xymph
Copy link
Copy Markdown
Collaborator Author

Xymph commented Aug 29, 2021

(I do have to mention that I feel a little uneasy with the time-traveling aspect of an earlier commit mentioning a concept that will be introduced in a later commit, but hey, nothing wrong with leaving a little mystery to the future code archeologists :P)

No offense intended, but would you have felt equally uneasy if I hadn't pointed it out explicitly?
Anyway, thanks for working with me, even into the future. 😉

@waldyrious
Copy link
Copy Markdown
Collaborator

No offense intended, but would you have felt equally uneasy if I hadn't pointed it out explicitly?

Good question! I would likely not have noticed it — or rather, I'd assume it already existed in the codebase, which I don't know nearly as intimately as you do 🙂.

@waldyrious waldyrious merged commit 498d669 into hamstar:master Aug 29, 2021
@Xymph Xymph deleted the 134-document-maxlag branch August 29, 2021 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants