Add WikimateException and centralize API error checks in request() #136
Merged
waldyrious merged 3 commits intohamstar:masterfrom Aug 31, 2021
Merged
Add WikimateException and centralize API error checks in request() #136waldyrious merged 3 commits intohamstar:masterfrom
waldyrious merged 3 commits intohamstar:masterfrom
Conversation
Collaborator
Yep, it can 🙂. You should hopefully see a "Still in progress? Convert to draft" in the PR sidebar (right below the "Reviewers" heading). |
Xymph
force-pushed
the
136-central-exception
branch
from
c64897e to
4169410
Compare
Collaborator
Author
|
One observation about 4169410: |
waldyrious
approved these changes
Aug 31, 2021
Collaborator
waldyrious
left a comment
waldyrious
left a comment
There was a problem hiding this comment.
LGTM! Just a minor grammar nit 😄
Xymph
force-pushed
the
136-central-exception
branch
from
5250870 to
6d88e77
Compare
This was referenced Aug 31, 2021
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the exception handling portion of #113, where the reasoning for this approach is discussed. Debug logging changes will go into separate PR #139, which will close that issue.
A commit with documentation/changelog edits follows after #135 is wrapped up and merged. (Hmm, I guess this should have been a draft PR. Can it still be changed?)