Skip to content

Add new method Wikimate::undelete()#153

Merged
waldyrious merged 1 commit intohamstar:masterfrom
Xymph:153-add-undelete
Jul 20, 2023
Merged

Add new method Wikimate::undelete()#153
waldyrious merged 1 commit intohamstar:masterfrom
Xymph:153-add-undelete

Conversation

@Xymph
Copy link
Copy Markdown
Collaborator

@Xymph Xymph commented Jul 20, 2023

New support for API call, with version-dependent undeletetalk parameter.
This clears my backlog of prepared code :) and I think it's a good time to wrap up v1.1.0.

@Xymph Xymph force-pushed the 153-add-undelete branch from 784d9c2 to 1caac52 Compare July 20, 2023 14:27
@Xymph Xymph requested a review from waldyrious July 20, 2023 14:27
Comment thread Wikimate.php Outdated
Comment thread Wikimate.php Outdated
@Xymph Xymph force-pushed the 153-add-undelete branch from 1caac52 to 538d9a9 Compare July 20, 2023 15:20
@Xymph Xymph force-pushed the 153-add-undelete branch from 538d9a9 to 4aa5c7f Compare July 20, 2023 16:04
Copy link
Copy Markdown
Collaborator

@waldyrious waldyrious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@waldyrious waldyrious merged commit 0a7e80b into hamstar:master Jul 20, 2023
@Xymph Xymph deleted the 153-add-undelete branch July 20, 2023 18:19
@Xymph
Copy link
Copy Markdown
Collaborator Author

Xymph commented Jul 20, 2023

Alright, so agree to wrap up v1.1.0?
This needs to include a link to #153 in Changelog, since I forgot that this time.

@Xymph Xymph mentioned this pull request Jul 20, 2023
@waldyrious
Copy link
Copy Markdown
Collaborator

Alright, so agree to wrap up v1.1.0?

Yep! Let's go!

This needs to include a link to #153 in Changelog, since I forgot that this time.

Ah, interesting. We might want to add some sort of markdown validation in the changelog checks, so that we confirm not just the presence but also the syntactic validity. I believe markdownlint is able to do this. (We'd have to disable the rule about duplicate headings though, by adding <!-- markdownlint-disable no-duplicate-heading --> to the top of the changelog file.)

@waldyrious
Copy link
Copy Markdown
Collaborator

Wait a moment... we already have a markdownlint check (#138, #146). Somehow it failed to detect the issue. Could it be that the **/*.md glob is failing to detect the files at the root of the repo? Either way, we should look into making the output of that script verbose, so that we at least know which files it looked into (even if it found no issues).

@waldyrious
Copy link
Copy Markdown
Collaborator

Opened #154 to address the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants