Skip to content

Clarify release instructions in GOVERNANCE.md#157

Merged
Xymph merged 1 commit intomasterfrom
clarify-release-instructions
Jul 31, 2023
Merged

Clarify release instructions in GOVERNANCE.md#157
Xymph merged 1 commit intomasterfrom
clarify-release-instructions

Conversation

@waldyrious
Copy link
Copy Markdown
Collaborator

@waldyrious waldyrious commented Jul 30, 2023

  • Move the SemVer info to the first step where the new version number is defined
  • Split the first step of the release preparation PR into two, for clarity
  • Mention that the new git tag is marked for creation in the release drafting page
  • Add a new step to publish a record of the actions taken in the release process
  • Minor wording adjustment: "relevant" → "corresponding"

@waldyrious waldyrious force-pushed the clarify-release-instructions branch from 3b2494c to e83f48b Compare July 30, 2023 23:11
@waldyrious waldyrious requested a review from Xymph July 30, 2023 23:11
@waldyrious waldyrious marked this pull request as draft July 30, 2023 23:46
Copy link
Copy Markdown
Collaborator

@Xymph Xymph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Postponing merge because of draft status.

- Move the SemVer info to the first step where the new version number is defined
- Split the first step of the release preparation PR into two, for clarity
- Mention that the new git tag is marked for creation in the release drafting page
- Add a new step to publish a record of the actions taken in the release process
- Minor wording adjustment: "relevant" → "corresponding"
@waldyrious waldyrious force-pushed the clarify-release-instructions branch from e83f48b to b4de92b Compare July 31, 2023 09:04
@waldyrious waldyrious marked this pull request as ready for review July 31, 2023 09:04
@waldyrious
Copy link
Copy Markdown
Collaborator Author

waldyrious commented Jul 31, 2023

Added an additional step that I forgot yesterday. The PR is ready now :)

@Xymph Xymph merged commit f845152 into master Jul 31, 2023
@waldyrious waldyrious deleted the clarify-release-instructions branch July 31, 2023 09:10
@waldyrious
Copy link
Copy Markdown
Collaborator Author

For the record, I pushed a commit directly to master with a minor edit following this PR. (I meant to add it here but @Xymph was faster! 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants