Open
Conversation
Contributor
|
@jaylinski This looks cool! Any plans to finish this? |
jaylinski
force-pushed
the
perf-upstream
branch
from
53a5f13 to
95c890e
Compare
Contributor
|
@jaylinski do we have benchmarks for this? |
Member
Author
Nope, I'm not even sure if the commit that is left does anything performance wise. I think it was just a cleanup to get the indices to start with |
kibertoad
approved these changes
Mar 25, 2026
Contributor
|
@jaylinski can we have a test for the change? |
Member
Author
|
@kibertoad What about the existing test that was adapted accordingly? |
Contributor
|
@jaylinski which one is it? |
Member
Author
|
@kibertoad This one: Apparently the change didn't affect any other tests. |
Contributor
|
then probably we need new ones. amd is going away |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked changes from 4.x: