✨ chore(crawler): rename binary from mqcr to mq-crawl and update references#1394
Open
✨ chore(crawler): rename binary from mqcr to mq-crawl and update references#1394
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the mq-crawler CLI binary from mqcr to mq-crawl and updates a subset of repository references to match the new executable name.
Changes:
- Rename the
mq-crawlerCargo[[bin]]frommqcrtomq-crawl. - Update
mq-crawlerREADME usage examples and Homebrew install snippet to usemq-crawl. - Adjust the crawler installer script to install
mq-crawland remove the previous symlink creation logic.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| scripts/install_crawler.sh | Switch installer to mq-crawl and remove symlink creation (but currently leaves mqcr-specific logic elsewhere). |
| crates/mq-crawler/README.md | Update documentation examples from mqcr to mq-crawl. |
| crates/mq-crawler/Cargo.toml | Rename produced binary to mq-crawl. |
| README.md | Add mq-crawler to the “External Tools” list. |
| @@ -240,19 +240,6 @@ install_mqcr() { | |||
| chmod +x "$MQ_BIN_DIR/$binary_name" | |||
|
|
|||
There was a problem hiding this comment.
This block removed creation of the mq-crawl symlink, but the script still appears to verify/describe installation in terms of mqcr + a mq-crawl symlink later on. Either restore a compatibility symlink (likely mqcr -> mq-crawl now that the primary binary is renamed) or update the verification/post-install instructions to reflect the new single-binary setup.
Suggested change
| # Create or update compatibility symlink for legacy mq-crawl name | |
| ln -sfn "$MQ_BIN_DIR/$binary_name" "$MQ_BIN_DIR/mq-crawl" | |
| log "Created compatibility symlink mq-crawl -> $binary_name in $MQ_BIN_DIR" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.