Implement incremental packed list (basic type list/vector) hashing#122
Merged
Implement incremental packed list (basic type list/vector) hashing#122
Conversation
mkalinin
approved these changes
Apr 23, 2019
Contributor
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
LGTM! There is a couple of cosmetic fixes might worth to be done.
| private MerkleTrie updatePackedTrie( | ||
| SSZListType type, | ||
| Object value, | ||
| BiFunction<Integer, Object, MerkleTrie> childVisitor, |
Contributor
There was a problem hiding this comment.
It appears that childVisitor is not used.
| int typeSize = basicListType.getElementType().getSize(); | ||
| int valsPerChunk = bytesPerChunk / typeSize; | ||
| if (valsPerChunk * typeSize != bytesPerChunk) { | ||
| throw new UnsupportedOperationException(""); |
Contributor
There was a problem hiding this comment.
Let's add some message here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the completion of PR #115
Also addresses one item of the issue #120
No special tricks comparing to non-packed lists except the support for serializing subLists were added