Update deposit contract according to v0.6.1#130
Conversation
|
Also I've not found this goddamn **** https://github.com/harmony-dev/beacon-chain-java/pull/130/files#diff-9b854443634f1745881ecae0970951edR174 anywhere except deposit contract sources. Am I correct it's really required and it couldn't be simplified? Also some docs suggests using call of |
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
There is a couple of notes. Otherwise, it looks good to me and ready to get merged.
| return zeroHashes[distanceFromBottom]; | ||
| } | ||
|
|
||
| // # Compute a Merkle root of a right-zerobyte-padded 2**32 sized tree |
There was a problem hiding this comment.
Where does this Python code come from? Could we annotate its source in a class header?
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
If we don't want to make Merkle tree properly abstracted at this stage then this PR is ready to get merged; I'd only like to see a couple of renames.
|
@mkalinin done |
Nashatyrev
left a comment
Nashatyrev
left a comment
There was a problem hiding this comment.
Just some minor notes...
|
@Nashatyrev ready for re-review |
3 participants
Some quotations to better understand this update:
As you see this PR doesn't look like a production version of deposit root/proofs supplier, so I will be glad to give any feedback and help to move it to something we could really use in production.