Implementing SSZ offset based variable size elements serialization#132
Merged
Implementing SSZ offset based variable size elements serialization#132
Conversation
# Conflicts: # ssz/src/main/java/org/ethereum/beacon/ssz/HasherSerializer.java # ssz/src/main/java/org/ethereum/beacon/ssz/visitor/SSZSimpleHasher.java
Nashatyrev
approved these changes
May 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving #124
Regarding removed
BytesValueconcat/wrap optimization:current optimization causes
StackOverflowErroron big lists, say, of 8192 elements (we have such lists in randao mixes, for example). At first I've tried to solve StackOverflow with 10c2543 but ongoing measurement shows that this optimization is not working anymore, at least for current SSZ implementation:so I've removed it finally. I guess, rebuilt SSZ need some new optimization at different view.