Conversation
…onPipelineChannelTest
…manual Logger init
… Add RPC disconnect and timeouts handling
…gs. Set node-name MDC for all threads. Tune logging
… verified blocks as well
…t unhandled Flux errors
zilm13
left a comment
zilm13
left a comment
There was a problem hiding this comment.
Looks perfect! Just some thoughts when looking around.
| ExpiredBlock, | ||
| InvalidBlock, | ||
| StateMismatch, | ||
| OtherError |
There was a problem hiding this comment.
I'd throw out OtherError until it is needed. Maybe we could keep staying with more concrete results.
There was a problem hiding this comment.
IMO, UnexpectedError reads better.
There was a problem hiding this comment.
And I think we definitely need a StateTransitionError to reflect SpecAssertionException that is thrown by the spec.
|
|
||
| BeaconBlockStorage getBlockStorage(); | ||
|
|
||
| DataSource<Hash32, BeaconBlockHeader> getBlockHeaderStorage(); |
There was a problem hiding this comment.
Why not wrap it with dedicated interface like others. Or, lets postpone it?
There was a problem hiding this comment.
Let's postpone, since I'm not yet sure how this header storage should be organized
| } | ||
| } | ||
|
|
||
| void chainStarted(ChainStart chainStartEvent) { |
There was a problem hiding this comment.
could we split this method to few smaller readable tasks?
There was a problem hiding this comment.
Yep, good question. I wanted to return to this when create it
| public abstract class ValidatorKeys { | ||
|
|
||
| public static class Generate extends ValidatorKeys { | ||
| private int count; |
There was a problem hiding this comment.
It would be great to see something like 10 per epoch or, say, one per every 10 slots.
There was a problem hiding this comment.
Not sure what do you mean...
| timeParameters: | ||
| SECONDS_PER_SLOT: 10 | ||
| MIN_ATTESTATION_INCLUSION_DELAY: 1 | ||
| SLOTS_PER_EPOCH: 2 No newline at end of file |
| * this block + all its descendants returned | ||
| * | ||
| * Blocks with height less than {@link #getTopBlock()} are dropped | ||
| * Blocks with height bigger than some threshold above {@link #getTopBlock()} are dropped |
There was a problem hiding this comment.
some threshold above sounds really like magic
…d this cause tasks submitted to already disconnected api
# Conflicts: # consensus/src/main/java/org/ethereum/beacon/consensus/verifier/operation/AttestationVerifier.java
mkalinin
left a comment
mkalinin
left a comment
There was a problem hiding this comment.
Network stack and sync process based on RX streams is something outstanding! Happy to merge this one.
…be downloaded for sync to proceed
3 participants
Implement wire protocol, add regular sync, peers and connections management