Merged
Conversation
# Conflicts: # start/common/src/main/java/org/ethereum/beacon/start/common/NodeLauncher.java # start/node/src/main/java/org/ethereum/beacon/node/NodeCommandLauncher.java # versions.gradle # wire/src/main/java/org/ethereum/beacon/wire/impl/plain/net/netty/NettyServer.java # wire/src/test/java/org/ethereum/beacon/wire/NodeTest.java
zilm13
reviewed
Sep 8, 2019
Member
zilm13
left a comment
zilm13
left a comment
There was a problem hiding this comment.
Titanic work is done by you. Gratz!!
| Libp2pLauncher libp2pLauncher = new Libp2pLauncher(); | ||
|
|
||
| if (networkCfg instanceof NettyNetwork) { | ||
| throw new UnsupportedOperationException("Netty network is not supported anymore"); |
Member
There was a problem hiding this comment.
Maybe add some kind of @Deprecated to NettyNetwork in this case?
Contributor
Author
There was a problem hiding this comment.
I will sort it out a bit later. May be it makes sense to get rid of NettyNetwork stuff completely, since old Netty and new Libp2p are pretty different in terms of interfaces
| .getActivePeers() | ||
| .stream() | ||
| .map( | ||
| a -> { |
Member
There was a problem hiding this comment.
we'd move it in future to separate parsers including enr parser
Contributor
Author
There was a problem hiding this comment.
Yep, this is now kind of temp format. Will stick to common format (other clients will be using) later
… feature/libp2p-integration
…s the issue with removing the disconnected peer from active sync list
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Libp2p integration.
Prerequisites: Libp2p-jvm published to local maven repo:
git clone https://github.com/libp2p/jvm-libp2p --branch feature/cleanup)> gradlew build> gradlew publishToMavenLocalWorking scenario (NOTE: either specify different --db-prefix for nodes or start them in different working dirs to avoid db file conflict) :
Node --name=v-01 --db-prefix=db1 --listen=40001 --validators=0-7 defaultNode --name=v-04 --db-prefix=db2 --validators=8-15 --connect=/ip4/127.0.0.1/tcp/40001:11111111111111111111111111111111111111111111111111111111111111111111 default(Travis failed due to absence of
libp2p-jvmartifact)--db-prefix option added. see usage example above.