Refactor method name to distinguish by parameter name#210
Merged
zilm13 merged 3 commits intoharmony-dev:feature/discv5-clientfrom Nov 25, 2019
shahankhatch:feature/discv5-client
Merged
Refactor method name to distinguish by parameter name#210zilm13 merged 3 commits intoharmony-dev:feature/discv5-clientfrom shahankhatch:feature/discv5-client
zilm13 merged 3 commits intoharmony-dev:feature/discv5-clientfrom
shahankhatch:feature/discv5-client
Conversation
Merged
Member
|
Cool, I like it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor is to make it clearer when magic is applied to the first parameter in
WhoAreYouPacket. For bothcreatemethods, I thought theBytesandBytes32types of the first parameter were too closely related, making it hard for me to distinguish when generalizing types (integration of this discv5 into Artemis uses TuweniBytes).