Error stack trace from server logs

[woodthom2]

Description

The Harmony server crashed on 3 Jan 2025 and this was the last entry in the server logs. It might be a coincidence and not the cause of the crash.

usr/local/lib/python3.10/site-packages/openpyxl/worksheet/_reader.py:329: UserWarning: Data Validation extension is not supported and will be removed
  warn(msg)
Traceback (most recent call last):
  File "/backend/./harmony/src/harmony/parsing/excel_parser.py", line 123, in convert_excel_to_instruments
    language = detect(" ".join(df_questions["question"]))
  File "/usr/local/lib/python3.10/site-packages/langdetect/detector_factory.py", line 130, in detect
    return detector.detect()
  File "/usr/local/lib/python3.10/site-packages/langdetect/detector.py", line 136, in detect
    probabilities = self.get_probabilities()
  File "/usr/local/lib/python3.10/site-packages/langdetect/detector.py", line 143, in get_probabilities
    self._detect_block()
  File "/usr/local/lib/python3.10/site-packages/langdetect/detector.py", line 150, in _detect_block
    raise LangDetectException(ErrorCode.CantDetectError, 'No features in text.')
langdetect.lang_detect_exception.LangDetectException: No features in text.
  File "/usr/local/lib/python3.10/threading.py", line 973, in _bootstrap
    self._bootstrap_inner()
  File "/usr/local/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
    self.run()
  File "/usr/local/lib/python3.10/site-packages/anyio/_backends/_asyncio.py", line 859, in run
    result = context.run(func, *args)
  File "/backend/harmony_api/routers/text_router.py", line 174, in parse_instruments
    new_instruments = convert_files_to_instruments(
  File "/backend/./harmony/src/harmony/parsing/wrapper_all_parsers.py", line 55, in convert_files_to_instruments
    instruments_from_this_file = _get_instruments_from_file(file)
  File "/backend/./harmony/src/harmony/parsing/wrapper_all_parsers.py", line 43, in _get_instruments_from_file
    instruments_from_this_file = convert_excel_to_instruments(file)
  File "/backend/./harmony/src/harmony/parsing/excel_parser.py", line 127, in convert_excel_to_instruments
    traceback.print_stack()
Error identifying language in Excel file
INFO:     193.61.168.178:2532 - "POST /text/parse HTTP/1.1" 200 OK
INFO:     193.61.168.178:5946 - "OPTIONS /text/match?include_catalogue_matches=true HTTP/1.1" 200 OK

Environment

Provide details regarding the operating system, toolchain, and environment.

How to Reproduce

1. This ran on CentOS with Docker container

I don't have the input that was loaded into the tool.

Expected Behaviour

Ideally we would not get an error

[carmel696]

Hello! This my first time working on an open source project. Could I take this issue and if so could I get a bit of guidance on how to get started? Thank you!

[SkylarEade]

Hi @woodthom2,

I've looked into the error traceback, and it seems like the crash might be caused by langdetect.detect() receiving empty or invalid input, leading to a LangDetectExceptionCode: No features in text. A possible solution could involve adding input validation to make sure the function processes only non-empty strings before calling detect().

Would it be okay if I investigate further and work on a fix? If so, could I be assigned to this issue?

[woodthom2]

Hi Skylar! thanks for looking into this! Yes please feel free to take the issue on. The comment is enough to show that you're assigned to it. Thanks and good luck

…

On Sat, 1 Mar 2025, 03:49 SkylarEade, ***@***.***> wrote: Hi @woodthom2 <https://github.com/woodthom2>, I've looked into the error traceback, and it seems like the crash might be caused by langdetect.detect() receiving empty or invalid input, leading to a LangDetectExceptionCode: No features in text. A possible solution could involve adding input validation to ensure the function processes only non-empty strings before calling detect(). Would it be okay if I investigate further and work on a fix? If so, could I be assigned to this issue? — Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUBTVNCGOCNX2RWZZMH7232SEU4PAVCNFSM6AAAAABUXQXULWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJRHEYDSMZYG4> . You are receiving this because you were mentioned.Message ID: ***@***.***> [image: SkylarEade]*SkylarEade* left a comment (harmonydata/harmony#76) <#76 (comment)> Hi @woodthom2 <https://github.com/woodthom2>, I've looked into the error traceback, and it seems like the crash might be caused by langdetect.detect() receiving empty or invalid input, leading to a LangDetectExceptionCode: No features in text. A possible solution could involve adding input validation to ensure the function processes only non-empty strings before calling detect(). Would it be okay if I investigate further and work on a fix? If so, could I be assigned to this issue? — Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADUBTVNCGOCNX2RWZZMH7232SEU4PAVCNFSM6AAAAABUXQXULWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOJRHEYDSMZYG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[woodthom2]

Hi @carmel696 sorry I missed your earlier message, feel free to get in contact on Discord (my name is thomas_55176), I don't know if @SkylarEade is working on it at present but you could connect and work together, or I'm happy to have a call and discuss it

[jaydugad]

Hi everyone, just a quick update—this issue is still open and available for contribution! If you're interested in working on it, feel free to comment or submit a PR.

[AvigailLaing]

@jaydugad Hello, I would be interested in working on this project.

[jaydugad]

Hi @AvigailLaing ,thanks for looking into this! Yes please feel free to take the issue on. If you want to discuss any doubt feel free to reach me on Discord: Jay Dugad.