Make hide_results_on_select option apply for deselecting as well#2924
Open
VanTanev wants to merge 6 commits intoharvesthq:mainfrom
Open
Make hide_results_on_select option apply for deselecting as well#2924VanTanev wants to merge 6 commits intoharvesthq:mainfrom
VanTanev wants to merge 6 commits intoharvesthq:mainfrom
Conversation
|
I believe this request is the same as what I'm looking for. To further explain, when using |
…elect-should-work-for-deselect
…on_select` is set
Author
|
Updated to also not scroll the dropdown menu to top when |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hide_results_on_select: falseoption currently applies only for selecting options. It should apply on deselect as well, as custom skinning of chosen can make use of it.Please double-check that:
package.json.I am unsure if this neccesitates a documentation change, as I think that this should have been the intended behavior of the option.