Skip to content

Make hide_results_on_select option apply for deselecting as well#2924

Open
VanTanev wants to merge 6 commits intoharvesthq:mainfrom
VanTanev:hide-results-on-select-should-work-for-deselect
Open

Make hide_results_on_select option apply for deselecting as well#2924
VanTanev wants to merge 6 commits intoharvesthq:mainfrom
VanTanev:hide-results-on-select-should-work-for-deselect

Conversation

@VanTanev
Copy link
Copy Markdown

Summary

hide_results_on_select: false option currently applies only for selecting options. It should apply on deselect as well, as custom skinning of chosen can make use of it.

Please double-check that:

  • All changes were made in CoffeeScript files, not JavaScript files.
  • You used Grunt to build the JavaScript files and tested them locally.
  • You've updated both the jQuery and Prototype versions.
  • You haven't manually updated the version number in package.json.
  • If necessary, you've updated the documentation. -
    I am unsure if this neccesitates a documentation change, as I think that this should have been the intended behavior of the option.

@cgatesman
Copy link
Copy Markdown

I believe this request is the same as what I'm looking for. To further explain, when using hide_results_on_select: false, it would be nice to be able to click on already selected items (which are currently greyed out) in order to unselect them (as if you clicked on the x of the .search-choice).

@VanTanev
Copy link
Copy Markdown
Author

Updated to also not scroll the dropdown menu to top when hide_results_on_select: false.

@JJJ JJJ mentioned this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants