feat: Adding FST architecture diagrams & documentation#387
Closed
deepak-swirlds wants to merge 4 commits intomainfrom
Closed
feat: Adding FST architecture diagrams & documentation#387deepak-swirlds wants to merge 4 commits intomainfrom
deepak-swirlds wants to merge 4 commits intomainfrom
Conversation
Signed-off-by: Deepak Mishra <deepak@swirldslabs.com>
Signed-off-by: Deepak Mishra <deepak@swirldslabs.com>
|
Kudos, SonarCloud Quality Gate passed! |
| - Platform Configuration | ||
| - config.txt | ||
| - Node Software Address Books | ||
| - account 101 .bin |
Contributor
There was a problem hiding this comment.
Suggested change
| - account 101 .bin | |
| - account 101 .bin |
Contributor
There was a problem hiding this comment.
what is the reason why 'get IPs of statefulset(s)' is listed twice?
Contributor
There was a problem hiding this comment.
what is the reason why '[all pods] copy hedera-build.zip' is listed twice?
leninmehedy
reviewed
Oct 17, 2023
Member
leninmehedy
left a comment
There was a problem hiding this comment.
Let's keep design docs in Notion until it is finalized. I don't see the need of merging it and store in the repo yet.
When we are merging interface definitions after a design sprint/round, we need to ensure proper doc blocks are added so that we can auto-generate proper java doc.
Member
|
@deepak-swirlds Let's put the design docs in Notion here and close this PR. |
Member
|
Closing it as discussed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Description
This pull request changes the following:
Related Issues