[HCP Telemetry] Periodic Refresh for Dynamic Telemetry Configuration#18168
Merged
[HCP Telemetry] Periodic Refresh for Dynamic Telemetry Configuration#18168
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New feature for HCP Telemetry that allows us to dynamically re-configure metrics export to HCP.
Background
Currently, we need to restart the Consul server to bring in any updates to filters, a new endpoint or new labels from the Consul Telemetry Gateway in HCP.
Ideally, we are able to modify these dynamically, which requires logic to continuously fetch new configuration and update it as necessary.
Implementation
This PR enables this functionality, with changes to :
TelemetryConfigProvider:time.Ticker.GetEndpoint(),GetFilters()andGetLabels()ConfigProviderinterface to access filters and labels.EndpointProviderinterface to access the endpoint.** Cleanup / Refactor ***
clientpackage was cleaned to separate out theTelemetryConfigobject to parse and convert objects.This refactor was necessary since now the TelemetryConfigProvider also fetches telemetry config. This avoid duplication of logic for the parsing of the endpoint, labels ,etc.
Testing & Reproduction steps
Links
PR Checklist