Properly parsing request body when http.NoBody is used#168
Open
tjasko wants to merge 1 commit intohashicorp:mainfrom
Open
Properly parsing request body when http.NoBody is used#168tjasko wants to merge 1 commit intohashicorp:mainfrom
http.NoBody is used#168tjasko wants to merge 1 commit intohashicorp:mainfrom
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix corrects a behavior when
http.NoBodyis used as the request body, as currently, theretryablehttp.getBodyReaderAndContentLength()function will return aReaderFuncthat when called returns anio.Reader, that will output a literal"0"string on the wire as the HTTP request body.As such, a fix & test has been implemented to no-op when
http.NoBodyis used.This issue was found as I was testing this library when a
POSTrequest was being done with no request body.