Convert OAS property names to valid Terraform identifiers#59
Merged
Conversation
bendbennett
approved these changes
Sep 26, 2023
bendbennett
left a comment
Contributor
There was a problem hiding this comment.
LGTM 🚀
The only thing I'm wondering about is whether codegen-openapi and codgen-spec should have any knowledge of "Terraform identifiers"? Perhaps we can discuss further out of band?
Member
Author
|
Chatted offline, for now we're going to introduce the name validation in |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #58
This ensures that OAS property names are converted to a valid Terraform identifier if needed and documents the expectations/caveats in the
DESIGN.md. This was a lot easier because of the refactoring done in #51 🙏🏻Notes
DESIGN.md, I also plan to add a call to thecodegen-specvalidate function before serializing to ensure an error is raised for that 👍🏻