Skip to content

Remove unnecessary conversion to tftypes in AttributePlanModifiers implementations#343

Merged
bflad merged 1 commit intomainfrom
detro/avoid_tftypes_conversion_when_unnecessary
May 23, 2022
Merged

Remove unnecessary conversion to tftypes in AttributePlanModifiers implementations#343
bflad merged 1 commit intomainfrom
detro/avoid_tftypes_conversion_when_unnecessary

Conversation

@detro
Copy link
Contributor

@detro detro commented May 23, 2022

Small follow up from #335

@detro detro requested a review from a team as a code owner May 23, 2022 10:38
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So fresh and so clean 🚀

@bflad bflad added this to the v0.9.0 milestone May 23, 2022
@bflad bflad added the tech-debt Issues tracking technical debt that we're carrying. label May 23, 2022
Copy link
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@detro detro force-pushed the detro/avoid_tftypes_conversion_when_unnecessary branch from 3be65d3 to ed14ba2 Compare May 23, 2022 11:54
@bflad bflad merged commit 91e4152 into main May 23, 2022
@bflad bflad deleted the detro/avoid_tftypes_conversion_when_unnecessary branch May 23, 2022 12:12
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tech-debt Issues tracking technical debt that we're carrying.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants