Skip to content

internal/fwschema: Validate leading numerics in attribute names#708

Merged
bflad merged 2 commits intomainfrom
bflad/leading-numerics-validation
Mar 30, 2023
Merged

internal/fwschema: Validate leading numerics in attribute names#708
bflad merged 2 commits intomainfrom
bflad/leading-numerics-validation

Conversation

@bflad
Copy link
Contributor

@bflad bflad commented Mar 30, 2023

Closes #705

The error diagnostic details will only contain this additional context if a numeric is detected.

Reference: #705

The error diagnostic details will only contain this additional context if a numeric is detected.
@bflad bflad added the enhancement New feature or request label Mar 30, 2023
@bflad bflad added this to the v1.3.0 milestone Mar 30, 2023
@bflad bflad requested a review from a team as a code owner March 30, 2023 15:40
Copy link
Member

@austinvalle austinvalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bflad bflad merged commit 5288e44 into main Mar 30, 2023
@bflad bflad deleted the bflad/leading-numerics-validation branch March 30, 2023 19:36
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance Attribute Name Validation to Handle Leading Numerics

2 participants