New Data Source: azurerm_mssql_managed_database by theonlyames · Pull Request #27026 · hashicorp/terraform-provider-azurerm

theonlyames · 2024-08-13T18:20:40Z

Community Note

Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

This PR adds a Data Source for the azurerm_mssql_managed_database resource.

My organization is prohibited from creating or deleting Azure Managed Instance resources through Terraform, but it still is useful for use to access the SQL MI databases as a Data Source as part of our multi-layer Terraform infrastructure.

PR Checklist

I have followed the guidelines in our Contributing Documentation.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Testing

My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

I lack a personal Azure subscription that I can use to perform acceptance tests.

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

New Data Source: azurerm_mssql_managed_database [New Data Source: azurerm_mssql_managed_database #27026]

This is a (please select all that apply):

New Feature (ie adding a service, resource, or data source)

Related Issue(s)

N/A

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

stephybun

Thanks for this PR @theonlyames! This is off to a good start, I left some comments in-line, if you could take a look then we can get this moving and hopefully into the provider soon.

internal/services/mssqlmanagedinstance/mssql_managed_database_data_source.go

internal/services/mssqlmanagedinstance/mssql_managed_database_data_source_test.go

theonlyames · 2024-08-20T12:32:46Z

Thanks for this PR @theonlyames! This is off to a good start, I left some comments in-line, if you could take a look then we can get this moving and hopefully into the provider soon.

Thanks for the feedback. I'll start on making those changes!

stephybun

Apologies for taking a while to circle back to this @theonlyames. I took another look through and there are a few things that would be great to have fixed up. Once that's done I can kick off the tests and we should be able to get this merged.

internal/services/mssqlmanagedinstance/mssql_managed_database_data_source.go

website/docs/d/mssql_managed_database.html.markdown

theonlyames · 2024-10-23T14:52:41Z

Apologies for taking a while to circle back to this @theonlyames. I took another look through and there are a few things that would be great to have fixed up. Once that's done I can kick off the tests and we should be able to get this merged.

I believe I have made all the changes you suggested. Thanks for the review.

stephybun

@theonlyames I think the CI will be fixed by performing a rebase. If you can do that and get those checks green then this should be good to go!

Removed Stray Comments Replaced Parent Manged Instance Resource arguments with managed_instance_id Cleanup Computed Args Formatted Code Updated Attributes

Co-authored-by: stephybun <steph@hashicorp.com>

Co-authored-by: stephybun steph@hashicorp.com

theonlyames · 2024-11-19T18:04:32Z

@theonlyames I think the CI will be fixed by performing a rebase. If you can do that and get those checks green then this should be good to go!

I have rebased my branch off of the main branch.

theonlyames · 2024-11-22T15:29:16Z

@theonlyames I think the CI will be fixed by performing a rebase. If you can do that and get those checks green then this should be good to go!

I have rebased my branch off of the main branch.

I believe I may have messed things up in the rebase. I will rework things

theonlyames · 2024-11-22T16:38:26Z

@theonlyames I think the CI will be fixed by performing a rebase. If you can do that and get those checks green then this should be good to go!

I have rebased my branch off of the main branch.

I believe I may have messed things up in the rebase. I will rework things

Should hopefully be all set now.

internal/services/mssqlmanagedinstance/mssql_managed_database_data_source_test.go

…data_source_test.go That makes sense. Thank you Co-authored-by: stephybun <steph@hashicorp.com>

stephybun

Thanks @theonlyames LGTM 🌸

github-actions · 2024-12-27T02:13:59Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

github-actions bot added documentation service/mssqlmanagedinstance size/XL labels Aug 13, 2024

theonlyames marked this pull request as ready for review August 13, 2024 20:05

theonlyames force-pushed the mssqlmanageddatabase_datasource branch from d45958c to 1a41f12 Compare August 13, 2024 20:21

stephybun suggested changes Aug 20, 2024

View reviewed changes

github-actions bot added the waiting-response label Aug 20, 2024

github-actions bot removed the waiting-response label Aug 20, 2024

theonlyames requested a review from stephybun August 21, 2024 14:06

rcskosir added the new-data-source label Oct 14, 2024

stephybun suggested changes Oct 23, 2024

View reviewed changes

github-actions bot added waiting-response size/L and removed waiting-response size/XL labels Oct 23, 2024

theonlyames requested review from a team and katbyte as code owners October 23, 2024 14:41

github-actions bot added waiting-response and removed waiting-response labels Oct 23, 2024

stephybun reviewed Nov 19, 2024

View reviewed changes

theonlyames and others added 5 commits November 19, 2024 11:30

Added MSSQL Managed Database Data Source

73b6d04

Grouped Imports

603a789

Removed Stray Comments Replaced Parent Manged Instance Resource arguments with managed_instance_id Cleanup Computed Args Formatted Code Updated Attributes

Apply suggestions from code review

d53b9ee

Co-authored-by: stephybun <steph@hashicorp.com>

Apply suggestions from code review

dc6715d

Co-authored-by: stephybun steph@hashicorp.com

Fixed Lint Errors

930e328

theonlyames force-pushed the mssqlmanageddatabase_datasource branch from 11c8d4d to 930e328 Compare November 19, 2024 16:36

github-actions bot removed the waiting-response label Nov 19, 2024

theonlyames requested a review from stephybun November 19, 2024 16:36

github-actions bot added waiting-response and removed waiting-response labels Nov 21, 2024

Adjusted mssql_managed_database_data_source

8be4eac

github-actions bot added size/XL and removed size/L labels Nov 22, 2024

github-actions bot added the waiting-response label Nov 25, 2024

stephybun reviewed Nov 25, 2024

View reviewed changes

internal/services/mssqlmanagedinstance/mssql_managed_database_data_source_test.go Outdated Show resolved Hide resolved

Update internal/services/mssqlmanagedinstance/mssql_managed_database_…

eade825

…data_source_test.go That makes sense. Thank you Co-authored-by: stephybun <steph@hashicorp.com>

github-actions bot added waiting-response and removed waiting-response labels Nov 25, 2024

Ran terraform fmt on mssql_managed_database_data_source_test.go

f4579e9

github-actions bot removed the waiting-response label Nov 25, 2024

stephybun approved these changes Nov 26, 2024

View reviewed changes

stephybun merged commit 1196cc9 into hashicorp:main Nov 26, 2024

github-actions bot added this to the v4.12.0 milestone Nov 26, 2024

stephybun added a commit that referenced this pull request Nov 26, 2024

Update for #27026

9f6abe5

github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2024

Conversation

theonlyames commented Aug 13, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Community Note

Description

PR Checklist

Testing

Change Log

Related Issue(s)

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

theonlyames commented Aug 20, 2024

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

theonlyames commented Oct 23, 2024

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

theonlyames commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

theonlyames commented Nov 22, 2024

Uh oh!

theonlyames commented Nov 22, 2024

Uh oh!

Uh oh!

stephybun left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

theonlyames commented Aug 13, 2024 •

edited

Loading

theonlyames commented Nov 19, 2024 •

edited

Loading