Skip to content

New Data Source: azurerm_mssql_managed_database #27026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stephybun merged 8 commits into from
Nov 26, 2024
Merged

New Data Source: azurerm_mssql_managed_database #27026

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
73b6d04
Added MSSQL Managed Database Data Source
theonlyames Aug 13, 2024
603a789
Grouped Imports
Aug 20, 2024
d53b9ee
Apply suggestions from code review
theonlyames Oct 23, 2024
dc6715d
Apply suggestions from code review
theonlyames Oct 23, 2024
930e328
Fixed Lint Errors
theonlyames Oct 23, 2024
8be4eac
Adjusted mssql_managed_database_data_source
theonlyames Nov 22, 2024
eade825
Update internal/services/mssqlmanagedinstance/mssql_managed_database_…
theonlyames Nov 25, 2024
f4579e9
Ran terraform fmt on mssql_managed_database_data_source_test.go
theonlyames Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Adjusted mssql_managed_database_data_source
  • Loading branch information
@theonlyames
theonlyames committed Nov 22, 2024
commit 8be4eac3ac5cf879fafe25853ec4fa3107ebafca
16 changes: 10 additions & 6 deletions internal/services/mssqlmanagedinstance/mssql_managed_database_data_source.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,9 @@ func (d MsSqlManagedDatabaseDataSource) Read() sdk.ResourceFunc {
}

id := commonids.NewSqlManagedInstanceDatabaseID(subscriptionId, managedInstanceId.ResourceGroupName, managedInstanceId.ManagedInstanceName, state.Name)
resp, err := client.Get(ctx, id.ResourceGroupName, id.ManagedInstanceName, id.DatabaseName)
resp, err := client.Get(ctx, id)
if err != nil {
if response.WasNotFound(resp.Response.Response) {
if response.WasNotFound(resp.HttpResponse) {
return fmt.Errorf("%s was not found", id)
}
return fmt.Errorf("retrieving %s: %v", id, err)
Expand All @@ -160,19 +160,23 @@ func (d MsSqlManagedDatabaseDataSource) Read() sdk.ResourceFunc {
ManagedInstanceId: managedInstanceId.ID(),
}

ltrResp, err := longTermRetentionClient.Get(ctx, id.ResourceGroupName, id.ManagedInstanceName, id.DatabaseName)
ltrResp, err := longTermRetentionClient.Get(ctx, id)
if err != nil {
return fmt.Errorf("retrieving Long Term Retention Policy for %s: %v", id, err)
}

model.LongTermRetentionPolicy = flattenLongTermRetentionPolicy(ltrResp)
if ltrResp.Model != nil && ltrResp.Model.Properties != nil {
model.LongTermRetentionPolicy = flattenLongTermRetentionPolicy(*ltrResp.Model.Properties)
}

shortTermRetentionResp, err := shortTermRetentionClient.Get(ctx, id.ResourceGroupName, id.ManagedInstanceName, id.DatabaseName)
shortTermRetentionResp, err := shortTermRetentionClient.Get(ctx, id)
if err != nil {
return fmt.Errorf("retrieving Short Term Retention Policy for %s: %v", id, err)
}

model.ShortTermRetentionDays = int64(pointer.From(shortTermRetentionResp.RetentionDays))
if shortTermRetentionResp.Model != nil && shortTermRetentionResp.Model.Properties != nil {
model.ShortTermRetentionDays = pointer.From(shortTermRetentionResp.Model.Properties.RetentionDays)
}

if v, ok := metadata.ResourceData.GetOk("point_in_time_restore"); ok {
model.PointInTimeRestore = flattenManagedDatabasePointInTimeRestore(v)
Expand Down