Skip to content

update formatting to display in code block #5097

Closed
pradeepbhadani wants to merge 4 commits intohashicorp:masterfrom
pradeepbhadani:master
Closed

update formatting to display in code block #5097
pradeepbhadani wants to merge 4 commits intohashicorp:masterfrom
pradeepbhadani:master

Conversation

@pradeepbhadani
Copy link
Copy Markdown
Contributor

Currently it does not display identity_namespace block as code block but display as below here https://www.terraform.io/docs/providers/google/r/container_cluster.html#identity_namespace

hcl workload_identity_config { identity_namespace = "${data.google_project.project.project_id}.svc.id.goog" }

Currently it does not display `identity_namespace` block as code block but display as below here https://www.terraform.io/docs/providers/google/r/container_cluster.html#identity_namespace

`hcl workload_identity_config { identity_namespace = "${data.google_project.project.project_id}.svc.id.goog" }`
@ghost ghost added the size/xs label Dec 6, 2019
@ghost ghost requested review from paddycarver December 6, 2019 09:25
@ghost ghost added the documentation label Dec 6, 2019
Fix hyperlink formatting
@pradeepbhadani
Copy link
Copy Markdown
Contributor Author

@paddycarver Can you take a look into this?

@pradeepbhadani
Copy link
Copy Markdown
Contributor Author

@danawillow

@paddycarver
Copy link
Copy Markdown
Contributor

This needs to be upstreamed, but for some reason my upstreaming isn't working. I'll get it working again in ~6 hours when more people are in the office, and get this upstreamed and merged. Sorry for the delay.

@pradeepbhadani
Copy link
Copy Markdown
Contributor Author

Thanks @paddycarver

@pradeepbhadani
Copy link
Copy Markdown
Contributor Author

@paddycarver Can you please merge this PR?

@pradeepbhadani
Copy link
Copy Markdown
Contributor Author

@danawillow

@paddycarver
Copy link
Copy Markdown
Contributor

Hey @pradeepbhadani. Because we're upstreaming this to https://github.com/GoogleCloudPlatform/magic-modules, the merge commit cef8041 makes merging this a pain. Any chance I could get you to rebase on master?

git pull origin master
git checkout fork master
git rebase -i origin/master

and drop the merge commit? I can also do this tomorrow, but it'll preserve less of the authorship information than if you do it. Let me know if you want to tackle this, and if I don't hear from you tomorrow, I'll go ahead and do it myself.

@pradeepbhadani
Copy link
Copy Markdown
Contributor Author

@paddycarver - For somereason above steps did not worked for me.
I have created a new PR which has these changes without commit cef8041.

New PR: #5207

@ghost
Copy link
Copy Markdown

ghost commented Mar 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants