update formatting to display in code block #5097
update formatting to display in code block #5097pradeepbhadani wants to merge 4 commits intohashicorp:masterfrom pradeepbhadani:master
Conversation
sync with remote
Currently it does not display `identity_namespace` block as code block but display as below here https://www.terraform.io/docs/providers/google/r/container_cluster.html#identity_namespace `hcl workload_identity_config { identity_namespace = "${data.google_project.project.project_id}.svc.id.goog" }`
Fix hyperlink formatting
|
@paddycarver Can you take a look into this? |
Fixes #5137
|
This needs to be upstreamed, but for some reason my upstreaming isn't working. I'll get it working again in ~6 hours when more people are in the office, and get this upstreamed and merged. Sorry for the delay. |
|
Thanks @paddycarver |
|
@paddycarver Can you please merge this PR? |
|
Hey @pradeepbhadani. Because we're upstreaming this to https://github.com/GoogleCloudPlatform/magic-modules, the merge commit cef8041 makes merging this a pain. Any chance I could get you to rebase on master? and drop the merge commit? I can also do this tomorrow, but it'll preserve less of the authorship information than if you do it. Let me know if you want to tackle this, and if I don't hear from you tomorrow, I'll go ahead and do it myself. |
|
@paddycarver - For somereason above steps did not worked for me. New PR: #5207 |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
Currently it does not display
identity_namespaceblock as code block but display as below here https://www.terraform.io/docs/providers/google/r/container_cluster.html#identity_namespacehcl workload_identity_config { identity_namespace = "${data.google_project.project.project_id}.svc.id.goog" }