Skip to content

add tests and docs for using custom service account in dataflow flex template job#7999

Merged
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-4ac9c2988eb69de64f8510022e55d21420cee6e9
Dec 11, 2020
Merged

add tests and docs for using custom service account in dataflow flex template job#7999
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-4ac9c2988eb69de64f8510022e55d21420cee6e9

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

fixes #7658

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

dataflow: added documentation about using `parameters` for custom service account and other pipeline options to `google_dataflow_flex_template_job`

Derived from GoogleCloudPlatform/magic-modules#4260

…template job (hashicorp#4260)

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Dec 11, 2020
@modular-magician modular-magician merged commit feee345 into hashicorp:master Dec 11, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jan 11, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 11, 2021
@modular-magician modular-magician deleted the downstream-pr-4ac9c2988eb69de64f8510022e55d21420cee6e9 branch November 17, 2024 00:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support service_account_email in google_dataflow_flex_template_job

1 participant