Skip to content

Eliminate retries in the inner loop for errors that will not succeed.#8080

Merged
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-0d5263f6a6516d7adb944cbc2aba0acfaad945ed
Dec 23, 2020
Merged

Eliminate retries in the inner loop for errors that will not succeed.#8080
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-0d5263f6a6516d7adb944cbc2aba0acfaad945ed

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

@modular-magician modular-magician commented Dec 23, 2020

Fixes #7853
Fixes #7940
Fixes #6833

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

filestore: updated retry logic to fail fast on quota error which cannot succeed on retry.
storage: updated IAM resources to refresh etag sooner on an IAM conflict error, which will make applications of multiple IAM resources much faster.

Derived from GoogleCloudPlatform/magic-modules#4334

…hashicorp#4334)

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/s label Dec 23, 2020
@modular-magician modular-magician merged commit d8d04b1 into hashicorp:master Dec 23, 2020
@ghost
Copy link
Copy Markdown

ghost commented Jan 23, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Jan 23, 2021
@modular-magician modular-magician deleted the downstream-pr-0d5263f6a6516d7adb944cbc2aba0acfaad945ed branch November 16, 2024 23:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

1 participant