Skip to content

Misc improvements for Certificate Authority#8249

Merged
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-f5c85ec3a1324555b5d0c4900550bd7a48723c13
Jan 19, 2021
Merged

Misc improvements for Certificate Authority#8249
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-f5c85ec3a1324555b5d0c4900550bd7a48723c13

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

google_privateca_certificate_authority_iam_policy
google_privateca_certificate_authority_iam_binding
google_privateca_certificate_authority_iam_member

This PR brings multiple UX improvements over the recently merged but unreleased GoogleCloudPlatform/magic-modules#4382. As such it would be nice if google_privateca_certificate_authority release waits to be released with these changes:

  1. Fix update.
  2. Mark multiple immutable fields as ForceNew.
  3. Small documentation improvements.
  4. Support for Customer-Managed Encryption Keys (CMEK).
  5. Adds a warning to the docs that CAs created during preview/terraform-provider-google-beta will be deleted before GA and should not be used in production (this note is already present in gcloud and the Console and was highlighted internally by the product team)
  6. Support for specifying reusableConfigs using the short form (in which case the Google-managed reusableConfig project is used.
  7. Adds a virtual attribute disable_on_delete that should be enabled to allow a CA to be deleted (same rationale of force_destroy on google_storage_bucket), and also only disable is the CA is in the enabled state.
  8. Adds support for SUBORDINATE CAs (activation should still be done manually via Console or gcloud, however).
  9. Adds IAM resources.

Derived from GoogleCloudPlatform/magic-modules#4407

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/l label Jan 19, 2021
@modular-magician modular-magician merged commit b89f5c0 into hashicorp:master Jan 19, 2021
@ghost
Copy link
Copy Markdown

ghost commented Feb 19, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2021
@modular-magician modular-magician deleted the downstream-pr-f5c85ec3a1324555b5d0c4900550bd7a48723c13 branch November 17, 2024 02:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant