Skip to content

compute: ignore error when delete operation is successful#8463

Merged
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-ddbe342494d6dc9bee6b6718c3710176ba10a3f5
Feb 12, 2021
Merged

compute: ignore error when delete operation is successful#8463
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-ddbe342494d6dc9bee6b6718c3710176ba10a3f5

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

Fixes #8422

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed an issue where the provider could return an error on a successful delete operation

Derived from GoogleCloudPlatform/magic-modules#4491

…4491)

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added the size/xs label Feb 12, 2021
@modular-magician modular-magician merged commit 71c15de into hashicorp:master Feb 12, 2021
@ghost
Copy link
Copy Markdown

ghost commented Mar 15, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 15, 2021
@modular-magician modular-magician deleted the downstream-pr-ddbe342494d6dc9bee6b6718c3710176ba10a3f5 branch November 17, 2024 01:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Compute instance: ignore 404 error on successful delete operation

1 participant