Suppress diff for COS images#8602
Merged
melinath merged 1 commit intohashicorp:masterfrom Mar 4, 2021
Merged
Conversation
ghost
requested a review
from 
melinath
approved these changes
Mar 3, 2021
Collaborator
melinath
left a comment
melinath
left a comment
There was a problem hiding this comment.
This LGTM. Thanks for creating a detailed ticket and adding unit tests! Seems to be in line with similar functionality for i.e. ubuntu. Would you be interested in upstreaming this yourself? Otherwise I can take that on.
Contributor
Author
|
Thanks for quick review! I'd appreciate it if you took on the upstreaming as I'm not comfortable with that process. |
5 tasks
This was referenced Mar 4, 2021
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks! |
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8601