Skip to content

Made project_service.service validation reject invalid service domains#8987

Merged
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-0086851d12e7ca7e87c47181820badd2717c8cd5
Apr 23, 2021
Merged

Made project_service.service validation reject invalid service domains#8987
modular-magician merged 1 commit intohashicorp:masterfrom
modular-magician:downstream-pr-0086851d12e7ca7e87c47181820badd2717c8cd5

Conversation

@modular-magician
Copy link
Copy Markdown
Collaborator

Resolved #8875

There are a variety of supported domains (and more may be added). I think adding a simple check for the domain being plausible (i.e. "does it contain a period") should catch simple typos like the one in the linked issue while also being future-proof.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

serviceusage: Made `google_project_service.service` validation reject invalid service domains that don't contain a period

Derived from GoogleCloudPlatform/magic-modules#4722

hashicorp#4722)

Signed-off-by: Modular Magician <magic-modules@google.com>
@ghost ghost added size/s labels Apr 23, 2021
@modular-magician modular-magician merged commit 93feb02 into hashicorp:master Apr 23, 2021
@ghost
Copy link
Copy Markdown

ghost commented May 24, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2021
@modular-magician modular-magician deleted the downstream-pr-0086851d12e7ca7e87c47181820badd2717c8cd5 branch November 17, 2024 00:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_project_service module needs to handle incorrect GCP API names properly

1 participant