Conversation
kalafut
approved these changes
Aug 10, 2020
Contributor
kalafut
left a comment
kalafut
left a comment
There was a problem hiding this comment.
LGTM.
Can you also update the API docs: https://www.vaultproject.io/api-docs/auth/jwt#jwt_supported_algs
calvn
pushed a commit
that referenced
this pull request
Aug 17, 2020
calvn
added a commit
that referenced
this pull request
Aug 17, 2020
kalafut
pushed a commit
that referenced
this pull request
Aug 17, 2020
kalafut
pushed a commit
to kalafut/vault-plugin-auth-jwt
that referenced
this pull request
Aug 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds EdDSA to the list of supported algorithms in the library. The underlying library already supports this implementation.