Merged
Conversation
… when no other roles have been created causes an error
Monkeychip
reviewed
Nov 19, 2020
Contributor
Monkeychip
left a comment
Monkeychip
left a comment
There was a problem hiding this comment.
Small test failure, but I tried to break this and couldn't. Nice fix.
…dd created options to list on delete
Monkeychip
approved these changes
Nov 23, 2020
| @@ -0,0 +1,4 @@ | |||
| ```release-note:bug | |||
Contributor
There was a problem hiding this comment.
nice. good idea to include changelog in the pr record. I'll start doing this as well.
chelshaw
added a commit
that referenced
this pull request
Dec 11, 2020
* Fix bug where adding and then removing a new role on a transformation when no other roles have been created causes an error * Update test on search-select to reflect new behavior which does not add created options to list on delete * Add changelog
chelshaw
added a commit
that referenced
this pull request
Dec 14, 2020
* Fix bug where adding and then removing a new role on a transformation when no other roles have been created causes an error * Update test on search-select to reflect new behavior which does not add created options to list on delete * Add changelog
Ali-Razmjoo
pushed a commit
to fork-the-planet/vault
that referenced
this pull request
Oct 28, 2025
Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding and then removing roles on a transformation when no roles have been created causes an error when removing them, which means they don't actually get removed from the model.
GIF of issue:
