Unconditionally use the root namespace when calling sys/seal-status.#10742
Merged
Unconditionally use the root namespace when calling sys/seal-status.#10742
Conversation
swayne275
approved these changes
Jan 25, 2021
HridoyRoy
pushed a commit
that referenced
this pull request
Jan 25, 2021
* feat(agent): add retry configuration for vault agent * feat(agent): add test fixtures for retry * fix(retry): move retry stanza to top level as template_retry * fix(retry): add retry config to ServerConfig struct * fix(retry): point config parser to parse template_retry instead of retry * remove netlify config (#10711) * Fix build (#10749) * Move the declaration to a OSS build tag file to not have it collide w… (#10750) * Move the declaration to a OSS build tag file to not have it collide with ent declarations * Add comment * Remove comment to trigger ci * Unconditionally use the root namespace when calling sys/seal-status. (#10742) * feat(agent): add retry configuration for vault agent * feat(agent): add test fixtures for retry * fix(retry): move retry stanza to top level as template_retry * fix(retry): add retry config to ServerConfig struct * fix(retry): point config parser to parse template_retry instead of retry Co-authored-by: Hridoy Roy <roy@hashicorp.com> Co-authored-by: Jeff Escalante <jescalan@users.noreply.github.com> Co-authored-by: Vishal Nayak <vishalnayak@users.noreply.github.com> Co-authored-by: Mark Gritter <mgritter@hashicorp.com>
mgritter
pushed a commit
that referenced
this pull request
Jan 25, 2021
mgritter
pushed a commit
that referenced
this pull request
Jan 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though PR #10725 and it accompanying enterprise PR added sys/seal-status to all namespaces, it will only be available there when Vault is unsealed.
v1/sys/seal-statusis the only point guaranteed to work, so this change ensures that is what gets called, ignoring the VAULT_NAMESPACE environment variable or a command line flag.