Merged
Conversation
…or the sake of a test.
briankassouf
approved these changes
Mar 19, 2021
Contributor
There was a problem hiding this comment.
Want to add docs? You can mostly copy from consul: https://www.consul.io/docs/agent/options#_raft_snapshot_interval. I'm fine if this happens in a subsequent PR too.
ncabatoff
added a commit
that referenced
this pull request
Mar 19, 2021
…or the sake of a test. (#11160)
tsaarni
pushed a commit
to Nordix/vault
that referenced
this pull request
Jan 8, 2026
…rp#10762) (hashicorp#11160) (hashicorp#11348) * sdk/rotation: Prevent rotation attempts on read-only storage Rotation is a write operation that mutates both Vault's storage and an external resource. Attempting this on a read-only node (like in a performance secondary cluster) will fail. This check preempts the rotation to prevent a split-brain scenario where the external credential is changed but Vault's storage cannot be updated. * changelog * fix failing test Co-authored-by: John-Michael Faircloth <fairclothjm@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...instead of setting it in prod code for the sake of a test.