Add ServerName to Vault Agent template config#11288
Merged
kalafut merged 4 commits intohashicorp:masterfrom May 13, 2021
pbar1:template-tls-server-name
Merged
Add ServerName to Vault Agent template config#11288kalafut merged 4 commits intohashicorp:masterfrom pbar1:template-tls-server-name
kalafut merged 4 commits intohashicorp:masterfrom
pbar1:template-tls-server-name
Conversation
Contributor
|
@ncabatoff @calvn Any chance we can get this into |
jasonodonnell
approved these changes
May 3, 2021
Contributor
jasonodonnell
left a comment
There was a problem hiding this comment.
I tested this and it worked as expected, however, I saw weird behavior where auto-auth would hang indefinitely if a bogus SNI was set. I'm looking deeper into this but don't think this is a blocker on this specific PR.
Contributor
|
Holding off on merging as we look into a possible bug uncovered by this. |
calvn
approved these changes
May 5, 2021
Contributor
|
@pbar1 We're ready to merge this but a CHANGELOG file for this change is needed. Once added we'll merge and backport this to the 1.7.x branch for the 1.7.2 release. Something like Thanks! |
Contributor
Author
|
Hey, I've been out for a few days. Sure - I'll add that changelog message. |
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
jasonodonnell
added a commit
that referenced
this pull request
May 13, 2021
* Add ServerName to Vault Agent template config * Remove newline * Add changelog for 11288 * Update changelog/11288.txt Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com> Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
jasonodonnell
added a commit
that referenced
this pull request
May 13, 2021
* Add ServerName to Vault Agent template config * Remove newline * Add changelog for 11288 * Update changelog/11288.txt Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com> Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com> Co-authored-by: Pierce Bartine <piercebartine@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening the closed #9401 here: