InfluxDB - Add username customization#11796
Merged
Conversation
|
|
Contributor
|
Nice! Will this be for 1.8? If so, please add the 1.8 Milestone to the PR. |
austingebauer
approved these changes
Jun 9, 2021
Contributor
austingebauer
left a comment
austingebauer
left a comment
There was a problem hiding this comment.
Looks good to me! Great job 👍
| import ( | ||
| "context" | ||
| "fmt" | ||
| "github.com/hashicorp/vault/sdk/helper/template" |
Contributor
There was a problem hiding this comment.
You may not have set this up already, but the goimports tool is useful to organize imports in a consistent way. I suggest to try running that tool on this file! I would expect to see this import grouped with the other group ("github.com/*") below.
This is just a stylistic suggestion. We usually try to organize imports consistently in Vault.
calvn
approved these changes
Jun 9, 2021
Contributor
calvn
left a comment
calvn
left a comment
There was a problem hiding this comment.
Same thoughts on imports as Austin mentioned, but otherwise looks great!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the ability to customize username generation for dynamic users in InfluxDB.
Uses the new field
username_templatewith the go template language.