UI: Show day of month instead of day of year in the expiration warning dialog#11984
Merged
mladlow merged 3 commits intohashicorp:mainfrom Sep 2, 2021
Merged
UI: Show day of month instead of day of year in the expiration warning dialog#11984mladlow merged 3 commits intohashicorp:mainfrom
mladlow merged 3 commits intohashicorp:mainfrom
Conversation
|
|
Contributor
|
Why wouldn't this little change be merged? |
Contributor
Author
|
I'm not authorized to merge. Can somebody with the right permissions merge? Thanks! |
hashishaw
approved these changes
Sep 2, 2021
Contributor
hashishaw
left a comment
hashishaw
left a comment
There was a problem hiding this comment.
Thank you for making this change!
Contributor
|
Hi @balent! Apologies for the delay on getting this merged. Would you be willing to refresh these code changes with the current |
Contributor
Author
|
Hi @hsimon-hashicorp I've just merged in the latest changes from the |
heatherezell
approved these changes
Sep 2, 2021
hashishaw
pushed a commit
that referenced
this pull request
Sep 3, 2021
…g dialog (#11984) * Show day of month instead of day of year in expiration warning dialog * Adding changelog
pull bot
pushed a commit
to NOUIY/vault
that referenced
this pull request
Jan 26, 2026
…1984) * VAULT-41962 Updated tools sidebar * Fix failing tests and add copyright header * Update capitailization of nav item titles * Update tools breadcrumbs * Add comments * Fix failing tests! * Update ui/tests/acceptance/config-ui/messages/messages-test.js * Update ui/lib/core/addon/components/sidebar/nav/tools.ts * Add more nav tests for custom messages * Update test name --------- Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11619