Skip to content

Fix Diagnose Formatting In Disk Usage Checks #12229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HridoyRoy merged 8 commits into from
Aug 2, 2021
Merged

Fix Diagnose Formatting In Disk Usage Checks #12229

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
33292ea
save
Jul 20, 2021
5454df9
fix diagnose formatting errors
Aug 2, 2021
ae0137f
fix diagnose formatting errors
Aug 2, 2021
e3fe0c5
Merge branch 'main' into diagnose-print-fix
Aug 2, 2021
5a79ead
change powers
Aug 2, 2021
7392d48
change powers
Aug 2, 2021
04fa33c
use humanize instead of doing the conversion to mb manually
Aug 2, 2021
cad6d8e
cl
Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions vault/diagnose/os_common.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ partLoop:
Warn(ctx, fmt.Sprintf("Could not obtain partition usage for %s: %v.", partition.Mountpoint, err))
} else {
if usage.UsedPercent > 95 {
SpotWarn(ctx, testName, fmt.Sprintf(partition.Mountpoint+" is %d percent full.", usage.UsedPercent),
Advice("It is recommended to have more than five percent of the partition free."))
SpotWarn(ctx, testName, fmt.Sprintf(partition.Mountpoint+" is %f percent full.", usage.UsedPercent))
Copy link
Collaborator

@ncabatoff ncabatoff Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I usually like to limit the number of digits of precision for float printfs, e.g. %.2f. Otherwise it can look ungainly.

Copy link
Contributor Author

@HridoyRoy HridoyRoy Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, didn't realize there was a simple way to make that nicer. Thanks, will do!

Advise(ctx, "It is recommended to have more than five percent of the partition free.")
} else if usage.Free < 2<<30 {
SpotWarn(ctx, testName, partition.Mountpoint+" has %d bytes full.",
Advice("It is recommended to have at least 1 GB of space free per partition."))
SpotWarn(ctx, testName, fmt.Sprintf(partition.Mountpoint+" has %d bytes free.", usage.Free))
Copy link
Collaborator

@ncabatoff ncabatoff Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bytes can be hard to read when we're talking about 8-9 digits. Maybe show as MBs or MiBs instead?

Copy link
Contributor Author

@HridoyRoy HridoyRoy Aug 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do!

Advise(ctx, "It is recommended to have at least 1 GB of space free per partition.")
} else {
SpotOk(ctx, testName, partition.Mountpoint+" usage ok.")
}
Expand Down