Conversation
…mporary), model requests correct endpoint
…orm if applicable
changelog/12800.txt
Outdated
| @@ -0,0 +1,3 @@ | |||
| ```release-note:feature | |||
| ui: OIDC Authorization Code Flow Support | |||
There was a problem hiding this comment.
Is this the new format that Meggie is requesting for features?
| @@ -0,0 +1,59 @@ | |||
| /** | |||
| * @module OidcConsentBlock | |||
| * OidcConsentBlock components are used to... | |||
| module('Unit | Controller | vault/cluster/identity/oidc-provider', function(hooks) { | ||
| setupTest(hooks); | ||
|
|
||
| // TODO: Replace this with your real tests. |
There was a problem hiding this comment.
is this coming in a later PR?
There was a problem hiding this comment.
Ah good catch. This file was automatically generated but we don't use route or controller tests, but I'll be following on with acceptance tests on a later PR 👍
Monkeychip
left a comment
Monkeychip
left a comment
There was a problem hiding this comment.
Looks like some failing UI tests and a couple of questions. But looks great!!!
|
Nice work!! Just one question, we are showing navigation bar during the login flow, is that fine? |
Good catch, we do want to hide the navigation links and I've handled that in the NavHeader component now 👍 |
hashicorp#12800) Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>
3 participants
Adds support for OIDC Authorization Code Flow with Vault as provider.
Assuming Vault as provider has already been set up under the name
my-provider, the client can make a URL request tohttps://my-vault.com/ui/vault/identity/oidc/provider/my-providerwith all required request parameters as query params. Example of valid url:https://localhost:4200/ui/vault/identity/oidc/provider/my-provider?scope=openid&response_type=code&client_id=abcd1234&redirect_uri=https%3A%2F%2Fexample.com%2FcallbackThe UI will handle a couple specific errors (shown below) and the rest will be returned to the client (provided in the redirect_uri param) with the
errorquery param.If prompt param = consent, the following screen will be shown assuming no other errors:
If the user denies consent, the screen will show this:
