Conversation
Example gap to-be-filledHere's is an example of a flow that backport-assistant will aid in
When
|
| - name: Backport changes to stable-website | ||
| run: | | ||
| backport-assistant backport -automerge |
There was a problem hiding this comment.
For now, only backport PRs to stable-website will be -automerge‘d
| GITHUB_TOKEN: ${{ secrets.ELEVATED_GITHUB_TOKEN }} | ||
| - name: Backport changes to latest release branch | ||
| run: | | ||
| resp=$(curl -f -s "https://api.github.com/repos/$GITHUB_REPOSITORY/releases?per_page=100") |
There was a problem hiding this comment.
I'm guessing GITHUB_REPOSITORY resolves to hashicorp/vault and not just vault? Once I started thinking about that, I think we'll need to introduce backport-assistant to vault-enterprise as well, otherwise we'd wind up with a different workflow on OSS vs ENT.
Edit: though we won't need the website backport components for the ent action.
There was a problem hiding this comment.
I'm guessing GITHUB_REPOSITORY resolves to hashicorp/vault and not just vault?
Yep! - resolves to {owner}/{repo}
Once I started thinking about that, I think we'll need to introduce backport-assistant to vault-enterprise as well, otherwise we'd wind up with a different workflow on OSS vs ENT.
Should I open a similar PR in https://github.com/hashicorp/vault-enterprise? (minus the website components)
There was a problem hiding this comment.
I'd appreciate it if you have time!
There was a problem hiding this comment.
@mladlow here's the Vault-ENT PR
I wasn't sure about the exact replacement for backport/website (given that it opens a backport PR against latest release/...) so I left a TBD comment.
|
This combination of jobs will backport anything labeled "backport/website" to both "stable-website" and the latest release branch, and will automerge the stable-website backports? I wanted to confirm my understanding based on my read of the yml. |
Co-authored-by: Meggie <meggie@hashicorp.com>
|
Re: #13163 (comment)
@mladlow yes, exactly that ^ The
|
mladlow
left a comment
mladlow
left a comment
There was a problem hiding this comment.
Approving per discussions other places.
* feat: add `backport.yml` * feat: check releases over labels for latest * chore: Do not automerge for non `stable-website` * chore: Do not automerge to not `stable-website` * Update .github/workflows/backport.yml Co-authored-by: Meggie <meggie@hashicorp.com> Co-authored-by: Meggie <meggie@hashicorp.com>
…shicorp#13163) Co-authored-by: Kianna <30884335+kiannaquach@users.noreply.github.com>
2 participants
Description
This introduces a workflow that uses backport-assistant to backport changes (primarily docs changes) to designated release/branches and/or stable-website
The incoming behavior based on Waypoint
Usage
This replaces docs-cherrypick with a set of new labels.
Labels:
stable-website(YES AUTOMERGE)release/{LATEST}(NO AUTOMERGE){LATEST}is determined by the greatest semver out of all GitHub releases that match a regex (^v\d+\.\d+\.\d+$)release/{TARGET}(NO AUTOMERGE)release/1.8.xWhy is this being proposed?
The intent is to provide a more flexible backporting flow that...
Dependencies
Requires a GitHub repo secret,
ELEVATED_GITHUB_TOKENto be created and added (should belong to a "hc-vault-bot" GitHub bot account)Requires GitHub labels to be created - ex: