Skip to content

Update example code links, remove unneeded comments#13491

Merged
digivava merged 1 commit intomainfrom
digivava/update-example-links
Dec 22, 2021
Merged

Update example code links, remove unneeded comments#13491
digivava merged 1 commit intomainfrom
digivava/update-example-links

Conversation

@digivava
Copy link
Copy Markdown
Collaborator

@digivava digivava commented Dec 21, 2021

We're in the process of restructuring the vault-examples repo to be concept-specific instead of language-specific.

Links will no longer be Go-specific, so we'll now point all links to the top level of the repo. (These links won't work until the PR on the vault-examples side is merged though, which I'm holding off until the last minute to reduce downtime.)

I also updated the code snippets in the docs to reflect the latest in the vault-examples repo, which mostly is just removing the operator-focused setup comments.

Copy link
Copy Markdown
Contributor

@yhyakuna yhyakuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

var password = kv2Secret.Data.Data["password"];

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: extra spaces

@digivava digivava merged commit c1495da into main Dec 22, 2021
@digivava digivava deleted the digivava/update-example-links branch December 22, 2021 17:33
digivava added a commit that referenced this pull request Jan 6, 2022
#13582)

* Backport: Update example code links, remove unneeded comments (#13491)

* Add nodes for OIDC pages

* Use only missing nodes
heppu pushed a commit to heppu/vault that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants