Skip to content

Add just the basic interfaces for managed keys to the OSS side.#13561

Merged
sgmiller merged 1 commit intomainfrom
managed-key-basics
Jan 4, 2022
Merged

Add just the basic interfaces for managed keys to the OSS side.#13561
sgmiller merged 1 commit intomainfrom
managed-key-basics

Conversation

@sgmiller
Copy link
Copy Markdown
Collaborator

@sgmiller sgmiller commented Jan 4, 2022

This will at least allow code to test whether the system view returned by
System() can be cast to ManagedKeySystemView, in which case you have access
to the managed key registry.

@sgmiller sgmiller requested a review from a team January 4, 2022 19:46
@sgmiller sgmiller changed the base branch from master to main January 4, 2022 19:46
@sgmiller sgmiller requested a review from a team January 4, 2022 19:48
@@ -0,0 +1,11 @@
package vault
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this have a negative enterprise build flag? Or will we remove these definitions from the enterprise side?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latter

Copy link
Copy Markdown
Contributor

@stevendpclark stevendpclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sgmiller sgmiller merged commit 4956a15 into main Jan 4, 2022
heppu pushed a commit to heppu/vault that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants